Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrappers.vector.HumanRendering #1069

Merged

Conversation

RogerJL
Copy link
Contributor

@RogerJL RogerJL commented May 28, 2024

fixed num_rows and num_cols
break loop when fewer environments that sub-images added tests

Description

Set the variables that are used, and do not index out of bounds

Fixes # (1068)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title Fix HumanRendering of vector environments (#1068) Fix wrappers.vector.HumanRendering May 30, 2024
@pseudo-rnd-thoughts
Copy link
Member

Thanks for the PR and adding testing.
I did some more comprehensive tests, see the updated testing file
Also, I found the old method of determining a sub-environment rendering x,y had issues so I updated that to better code

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 04fb345 into Farama-Foundation:main May 31, 2024
9 checks passed
@RogerJL RogerJL deleted the FixHumanVectorRendering branch May 31, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants