Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remove BaseMujocoEnv class #1075

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

Kallinteris-Andreas
Copy link
Collaborator

Description

Merged MujocoEnv and BaseMujocoEnv into MujocoEnv

also improves some docstrings

BaseMujocoEnv was created to be a super class of MujocoEnv and the old MujocoPyEnv which is no longer developed

validation: for 1mil steps identical behavior was observed https://github.com/Kallinteris-Andreas/gymnasium-changes-validation/tree/main/refactor_mujoco_class

Type of change

  • Refactor
  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review June 1, 2024 08:39
@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as draft June 1, 2024 08:39
@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review June 1, 2024 10:16
@Kallinteris-Andreas
Copy link
Collaborator Author

CI is falling due to a FFMPEG/ IMAGEIO issue, not related to this PR

@pseudo-rnd-thoughts
Copy link
Member

From the looks of it, this is related to https://github.com/imageio/imageio-ffmpeg/releases updating yesterday with v0.5.0 which was fixed to v0.5.1
Running a quick CI, I couldn't reproduce the error https://github.com/pseudo-rnd-thoughts/Gymnasium/actions/runs/9374573608/job/25810901875
I think you should just be able to do a git commit --allow-empty -m "Trigger Build" to fix it

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit b984e6b into Farama-Foundation:main Jun 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants