Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing NotImplementedError for VectorEnv.step #1102

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Add missing NotImplementedError for VectorEnv.step #1102

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1f83d3
fix some typehints
jet-sony Jul 1, 2024
15291d0
fix precommit
jet-sony Jul 2, 2024
d8abe03
revert change1
jet-sony Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gymnasium/vector/vector_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ def step(
>>> infos
{}
"""
raise NotImplementedError(f"{self.__str__()} step function is not implemented.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem helpful to include

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how the formatter didn't catch this function without a body. Is that normal?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because the docstring counts as a function component


def render(self) -> tuple[RenderFrame, ...] | None:
"""Returns the rendered frames from the parallel environments.
Expand Down
Loading