Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling in plots #1259

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

grekiki2
Copy link
Contributor

@grekiki2 grekiki2 commented Nov 21, 2024

Description

The convolution added in 28d50ce doesn't average over 100 frames but sums them instead.

Type of change

Please delete options that are not relevant.

  • Documentation only change (code changed)

The convolution added in Farama-Foundation@28d50ce doesn't average over 100 frames but sums them instead.
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 9ba3283 into Farama-Foundation:main Nov 22, 2024
13 checks passed
@grekiki2 grekiki2 deleted the patch-1 branch November 22, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants