Merge v1.0.0 #682
Merged
Merge v1.0.0 #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kallinteris Andreas <[email protected]>
Co-authored-by: Kallinteris Andreas <[email protected]>
# Conflicts: # docs/environments/third_party_environments.md # gymnasium/core.py
|
A couple more PRs to merge |
…with different action / obs spaces (Farama-Foundation#686)
# Conflicts: # gymnasium/wrappers/vector/vectorize_observation.py # tests/vector/test_vector_env.py # tests/vector/test_vector_env_info.py # tests/wrappers/vector/test_dict_info_to_list.py
…onalJaxEnv` and `FunctionalVectorJaxEnv`
# Conflicts: # gymnasium/spaces/utils.py # gymnasium/utils/env_checker.py
|
Need any help reviewing? |
|
@jjshoots That'd be great if you have some time to spare. I'll have to go through it at some point either way, but any bug you find, I won't have to find, so it's definitely helpful |
|
Thanks @jjshoots, it's only a small one 😅 Let me know if there is any part that doesn't make any sense |
RedTachyon
requested changes
Oct 8, 2023
There was a problem hiding this comment.
Things that should be done for 1.0.0 but I'm not sure are:
- Custom envs should play nice with async envs (I think this doesn't work right now)
- Potentially some basic API support for actually async envs? (separate async_step and wait_step) This sorta used to be present in old vector envs, we might want to refine it
- Spaces should in some way be chill with jax/torch arrays
- Maybe the jax-accelerated versions of some envs
- Probably something else that I don't remember now
Main things to rereview/rethink/refine:
gym.make_vec- Sync/Async vector envs (we need to revise it w.r.t. the autoreset behavior anyways)
Disclaimer: I skipped most of the docs, tests, and wrappers (assuming they're mostly relocated wrappers that were already present) in the review to make this tractable. We'll have to do a trial by fire via an alpha release anyways
# Conflicts: # .github/workflows/build-docs.yml # .github/workflows/docs-manual-versioning.yml # .github/workflows/docs-versioning.yml # docs/api/experimental/functional.md # docs/api/wrappers.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v1.0.0 has been a preparation branch to make a number of changes for v1.0.0 while allowing changes to made to main.
This PR merges v1.0.0 and main together