Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update env_checker.py #708

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Update env_checker.py #708

merged 4 commits into from
Sep 8, 2023

Conversation

chrisyeh96
Copy link
Contributor

Fix typo about Box maximum limit. Add return type annotations.

@chrisyeh96
Update env_checker.py
aea38c3 
Fix typo about Box maximum limit. Add return type annotations.
@pseudo-rnd-thoughts
Copy link
Member

Thanks for spotting that, could you fix the tests. You should just need to update the IGNORE_WARNINGS list to include the new case

@chrisyeh96
Copy link
Contributor Author

@pseudo-rnd-thoughts: I have updated the CHECK_ENV_IGNORE_WARNINGS list

@chrisyeh96
Copy link
Contributor Author

Updated the CHECK_ENV_IGNORE_WARNINGS in two more test files. This should fix the failing tests.

pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the changes

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit d9a8d66 into Farama-Foundation:main Sep 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisyeh96 @pseudo-rnd-thoughts