Add make(max_episode_steps=0) to not apply a TimeLimit wrapper
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an environment spec has a
max_episode_stepsthat is notNonethen there is no way of users to remove theTimeLimitwrapper from the environment stack (without setting an extremely high max episode steps limit)Therefore, this PR adds a special cases to
max_episode_stepsfor0(Nonewas taken as the default value) in order to disable applying the max episode steps parameter. This is very helpful for async or sync vector environments where modifying the environment stack is highly difficult, in particular, async vector env.