Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spark-sched-sim to third_party_environments.md #723

Merged

Conversation

ArchieGertsman
Copy link
Contributor

Description

I have added a new third party environment: spark-sched-sim.

Type of change

  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third-party has split into Gymnasium and Gym projects, could you change it to place the project in the gymnasium part (in alphabetical order)

@ArchieGertsman
Copy link
Contributor Author

The third-party has split into Gymnasium and Gym projects, could you change it to place the project in the gymnasium part (in alphabetical order)

Done!

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks. I forgot to mention but the project looks really cool. I did some work years ago on cloud resource allocation / job allocation with RL but no way near as cool as this

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 54d2ba7 into Farama-Foundation:main Sep 27, 2023
11 checks passed
@ArchieGertsman ArchieGertsman deleted the addthirdparty branch September 27, 2023 15:51
@ArchieGertsman
Copy link
Contributor Author

Amazing, thanks. I forgot to mention but the project looks really cool. I did some work years ago on cloud resource allocation / job allocation with RL but no way near as cool as this

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants