Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MuJoCo] add render arguments to the documention #744

Merged

Conversation

Kallinteris-Andreas
Copy link
Collaborator

Description

Adds a short description of the available arguments for changing the render properties of MuJoCo environments
I am not sure if the main page of MuJoCo is place to place the descriptions, if you have different suggestions of where to put them, i can move them

Fixes # (issue)

Type of change

  • doc update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this is super helpful.
Could you look at the two comments then I think we are good to merge

docs/environments/mujoco.md Outdated Show resolved Hide resolved
|`camera_name` |**str \| None**| `None` | The name of the camera used (mutally exclusive option with `camera_id`). |
|`default_camera_config` |**Dict[str, Union[float, int]] \| None** | `None` | The [mjvcamera](https://mujoco.readthedocs.io/en/stable/APIreference/APItypes.html?highlight=camera#mjvcamera) properties. |
|`max_geom` | **int** | `1000` | Max number of geometrical objects to render (useful for 3rd-party environments).|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an example script here to initialize an environment with some of these arguments

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 80697d9 into Farama-Foundation:main Oct 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants