Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore render support for mujoco<3 #750

Merged
merged 7 commits into from
Oct 23, 2023
Merged

restore render support for mujoco<3 #750

merged 7 commits into from
Oct 23, 2023

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Oct 21, 2023 •
edited
Loading

Description

This PR re-enables rendering support for all mujuco version from 2.1.5 to 3.0.0

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review October 23, 2023 07:47
pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, all we have done is all support for mujoco 3.0 but not removed support for 2.1.5?

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit db18efb into Farama-Foundation:main Oct 23, 2023
11 checks passed
@Kallinteris-Andreas
Copy link
Collaborator Author

Kallinteris-Andreas commented Oct 23, 2023 •
edited
Loading

yup all versions from 2.1.5 to 3.0 are supported

@traversaro traversaro mentioned this pull request Feb 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kallinteris-Andreas @pseudo-rnd-thoughts