Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MuJoCo] factorize _get_rew() out of step() #819

Merged
merged 27 commits into from
Dec 6, 2023

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Dec 6, 2023

Description

factorizes the "reward function" of the step() function into its own function _get_rew(), similarly to _get_obs()

a change inspired by robosuite

motivation

makes the code easier to read/maintain, also should make port to MJX easier

validation

in the repo: https://github.com/Kallinteris-Andreas/gymnasium-changes-validation/tree/main/get_rew_factorization
I validated that over 1 mil steps the behavior is identical for all environments
and observed no measurable runtime slowdown

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as draft December 6, 2023 13:25
@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review December 6, 2023 17:37
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 14def07 into Farama-Foundation:main Dec 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants