-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MuJoCo] factorize _get_rew()
out of step()
#819
Merged
pseudo-rnd-thoughts
merged 27 commits into
Farama-Foundation:main
from
Kallinteris-Andreas:mjx
Dec 6, 2023
Merged
[MuJoCo] factorize _get_rew()
out of step()
#819
pseudo-rnd-thoughts
merged 27 commits into
Farama-Foundation:main
from
Kallinteris-Andreas:mjx
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
factorizes the "reward function" of the
step()
function into its own function_get_rew()
, similarly to_get_obs()
a change inspired by robosuite
motivation
makes the code easier to read/maintain, also should make port to
MJX
easiervalidation
in the repo: https://github.com/Kallinteris-Andreas/gymnasium-changes-validation/tree/main/get_rew_factorization
I validated that over 1 mil steps the behavior is identical for all environments
and observed no measurable runtime slowdown
Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)