Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop exporting MuJoCo-v2 environment bases classes and export MujocoRenderer #827

Merged

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Dec 8, 2023

Description

Fixes #826

as a necessity, it also changes the registration of MuJoCo-v2 environments into

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

from gymnasium.envs.mujoco.reacher import ReacherEnv
from gymnasium.envs.mujoco.swimmer import SwimmerEnv
from gymnasium.envs.mujoco.walker2d import Walker2dEnv
from gymnasium.envs.mujoco.mujoco_env import MujocoEnv, MuJocoPyEnv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not export the rendering classes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pseudo-rnd-thoughts no we do not
metaworld imports and uses MujocoEnv() which uses the render utilities internally.
robotics imports and uses MujocoRenderer() which uses the viewer classes

I have added the exportation of MujocoRenderer() as that may be useful for third_party environments

@Kallinteris-Andreas Kallinteris-Andreas changed the title stop export MuJoCo-v2 environment bases classes stop exporting MuJoCo-v2 environment bases classes Dec 8, 2023
@Kallinteris-Andreas Kallinteris-Andreas changed the title stop exporting MuJoCo-v2 environment bases classes Stop exporting MuJoCo-v2 environment bases classes and export MujocoRenderer Dec 8, 2023
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the renderers

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit ede2ed1 into Farama-Foundation:main Dec 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Why are we exporting env classes of MuJoCo-v2 environments
2 participants