Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] MuJoCo-V5 blog post #945

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Mar 1, 2024

This is not to be merged in this repo, this is for a blog post.

Any and all Critiques are welcome, note: any reviewers comments can be treated independently (no need to read other's review for you to leave your own)

blog.md Outdated Show resolved Hide resolved
blog.md Show resolved Hide resolved
@elliottower
Copy link
Contributor

Already gave some initial thoughts a few weeks ago but it looks like you’ve addressed most of the things I mentioned, nothing more from me really. Idk if training graphs comparing env params would fit in the blog post I think it’s probably supposed to be more high level details than that usually, unless v5 makes difficulty change somehow

blog.md Outdated Show resolved Hide resolved

Numerous RL research papers have utilized Gymnasium/MuJoCo environments, including Hopper, Ant, and Humanoid. As a standard set of difficult-to-solve robotic environments, they have been a cornerstone in the development and evaluation of RL methods.
## MuJoCo v5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rereading this, I feel this whole section should be moved into the introduction as it is a summary what we have do

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you want the subsection "A quick history of MuJoCo environments" to be after "MuJoCo v5" subsection?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not, I will have another look

blog.md Show resolved Hide resolved
-- Fixed several `info` fields.
-- Walker2D: Both feet now have `friction==1.9`, previously the right foot had `friction==0.9` and the left foot had `friction==1.9` (related [GitHub issue](https://github.com/Farama-Foundation/Gymnasium/issues/477)).
-- Pusher: Fixed the issue of the object being lighter than air, (related [GitHub issue](https://github.com/Farama-Foundation/Gymnasium/issues/950)).
## Key features:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a for a complete changes made see XYZ and the related PR X

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the thing that is at the very bottom of the blog?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I would move it further up such that you don't need to get to the bottom to read it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really matter where it is? I believe it is preferable to be at the bottom since most users do not need to look at a complete changelog, but I can not move it if you really care

@Kallinteris-Andreas
Copy link
Collaborator Author

@pseudo-rnd-thoughts If you have no further comments/requests, feel free to publish it.

I am happy with the current version

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kallinteris-Andreas A couple of suggested changes, otherwise, good to have on farama.org

@jkterry1 What do we need to do to host on farama.org

blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved
blog.md Outdated Show resolved Hide resolved

Here all we have to do is change the `xml_file` argument, and set the `healthy_z_range`, because the robot has a different height than the default `Ant` robot. In general, we will have to change the `healthy_z_range` to fit the robot.

<iframe id="odysee-iframe" width="560" height="315" src="https://odysee.com/$/embed/@Kallinteris-Andreas:7/ANYmal_B_trained_using_SAC_on_gymnasium_mujoco-v5_framework:1?r=6fn5jA9uZQUZXGKVpwtqjz1eyJcS3hj3" allowfullscreen></iframe>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these videos be hosted on the website?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you can feel free to do so

I am not sure if the website can handle the bandwidth for video playback though, @mgoulao should know

@jkterry1
Copy link
Member

@pseudo-rnd-thoughts You can just message Manuel and he'll put it up on the website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants