Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update agilerl tutorials #1238

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mikepratt1
Copy link
Contributor

@mikepratt1 mikepratt1 commented Oct 25, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nicku-a nicku-a mentioned this pull request Oct 25, 2024
7 tasks
@David-GERARD
Copy link
Collaborator

David-GERARD commented Dec 4, 2024

@nicku-a @mikepratt1 the CI testing workflows for agilerl are returning an error, can you look into it?

╭───────────────────── Traceback (most recent call last) ──────────────────────╮
│ /home/runner/work/PettingZoo/PettingZoo/tutorials/AgileRL/agilerl_dqn_curric │
│ ulum.py:19 in <module>                                                       │
│                                                                              │
│     16 from agilerl.components.replay_buffer import ReplayBuffer             │
│     17 from agilerl.hpo.mutation import Mutations                            │
│     18 from agilerl.hpo.tournament import TournamentSelection                │
│ ❱   19 from agilerl.utils.utils import create_population                     │
│     20 from tqdm import tqdm, trange                                         │
│     21                                                                       │
│     22 from pettingzoo.classic import connect_four_v3                        │
╰──────────────────────────────────────────────────────────────────────────────╯
ImportError: cannot import name 'create_population' from 'agilerl.utils.utils' 
(/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/agilerl/ut
ils/utils.py)
Error: Process completed with exit code 1.

@nicku-a
Copy link
Contributor

nicku-a commented Dec 4, 2024

on it - just need to update the agilerl version in reqs

@@ -18,7 +18,8 @@ jobs:

matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
tutorial: [Tianshou, CustomEnvironment, CleanRL, SB3/kaz, SB3/waterworld, SB3/test] # TODO: fix tutorials and add back Ray, fix SB3/connect_four tutorial
tutorial: [Tianshou, CustomEnvironment, CleanRL, SB3/kaz, SB3/waterworld, SB3/connect_four, SB3/test] # TODO: fix tutorials and add back Ray
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SB3/connect_four must be removed as it is currently broken.

@David-GERARD
Copy link
Collaborator

I checked the new error logs, the workflows for python 3.10 and 3.11 failed because of a pygame version dependancy conflict between agilerl and PettingZoo 1.24.x. I have the same issue for another PR and I'm working on solving it.

Caution

However for the python 3.9 test of the agilerl tutorial, we have in the log:

Ignoring agilerl: markers 'python_version >= "3.10"' don't match your environment

which leads to a ModuleNotFoundError.

@mikepratt1 let me know if 'python_version >= "3.10"' is something you want to enforce, in which case we need to modify the CI to remove 3.9.

@David-GERARD David-GERARD added the enhancement New feature or request label Dec 4, 2024
@David-GERARD David-GERARD added this to the 1.24.4 release milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants