-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update agilerl tutorials #1238
base: master
Are you sure you want to change the base?
update agilerl tutorials #1238
Conversation
@nicku-a @mikepratt1 the CI testing workflows for agilerl are returning an error, can you look into it? ╭───────────────────── Traceback (most recent call last) ──────────────────────╮
│ /home/runner/work/PettingZoo/PettingZoo/tutorials/AgileRL/agilerl_dqn_curric │
│ ulum.py:19 in <module> │
│ │
│ 16 from agilerl.components.replay_buffer import ReplayBuffer │
│ 17 from agilerl.hpo.mutation import Mutations │
│ 18 from agilerl.hpo.tournament import TournamentSelection │
│ ❱ 19 from agilerl.utils.utils import create_population │
│ 20 from tqdm import tqdm, trange │
│ 21 │
│ 22 from pettingzoo.classic import connect_four_v3 │
╰──────────────────────────────────────────────────────────────────────────────╯
ImportError: cannot import name 'create_population' from 'agilerl.utils.utils'
(/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/agilerl/ut
ils/utils.py)
Error: Process completed with exit code 1. |
on it - just need to update the agilerl version in reqs |
Agilerl updates
- Update python version to 3.10
@@ -18,7 +18,8 @@ jobs: | |||
|
|||
matrix: | |||
python-version: ['3.8', '3.9', '3.10', '3.11'] | |||
tutorial: [Tianshou, CustomEnvironment, CleanRL, SB3/kaz, SB3/waterworld, SB3/test] # TODO: fix tutorials and add back Ray, fix SB3/connect_four tutorial | |||
tutorial: [Tianshou, CustomEnvironment, CleanRL, SB3/kaz, SB3/waterworld, SB3/connect_four, SB3/test] # TODO: fix tutorials and add back Ray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SB3/connect_four must be removed as it is currently broken.
I checked the new error logs, the workflows for python 3.10 and 3.11 failed because of a pygame version dependancy conflict between agilerl and PettingZoo 1.24.x. I have the same issue for another PR and I'm working on solving it. Caution However for the python 3.9 test of the agilerl tutorial, we have in the log: Ignoring agilerl: markers 'python_version >= "3.10"' don't match your environment which leads to a @mikepratt1 let me know if 'python_version >= "3.10"' is something you want to enforce, in which case we need to modify the CI to remove 3.9. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue), Depends on # (pull request)
Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.