Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update aec_rps.py #1248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liuzhaoze
Copy link

@liuzhaoze liuzhaoze commented Dec 9, 2024

Description

Update code in the documentation.

Type of change

  • This change requires a documentation update

Reason

All environments use self.observation_spaces and self.action_spaces to define observation spaces and action spaces, rather than self._observation_spaces and self._action_spaces. So, I think it is necessary to fix it to ensure consistency.

In addition, I modified the observation_space and action_space methods to obtain the observation space and action space through dict self.observation_spaces and self.action_spaces to correspond with the comment on L78.

I did not modify the observation_space and action_space methods in parallel_rps.py because observation spaces and action spaces are defined in them rather than self.observation_spaces and self.action_spaces.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@David-GERARD David-GERARD self-assigned this Dec 9, 2024
@David-GERARD David-GERARD added this to the 1.24.4 release milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants