Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DmLab tests #116

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pseudo-rnd-thoughts
Copy link
Member

Description

The CI hasn't been run for a while, just checking that everything still works

@pseudo-rnd-thoughts
Copy link
Member Author

@elliottower Do you know why the DM-Lab tests are not failing?

@elliottower
Copy link
Member

@elliottower Do you know why the DM-Lab tests are not failing?

Sorry didn’t see this until now, but am not sure. Took a look and the error seems to be exiting with code 5 but no error message in the action, and pytest has only a warning listed. So it may just be a one off GitHub actions issue, not sure

@pseudo-rnd-thoughts
Copy link
Member Author

pseudo-rnd-thoughts commented Mar 7, 2024

According to this stack overflow, error 5 occurs when no tests are run which matches the test case https://stackoverflow.com/questions/78061349/why-do-i-get-error-build-process-completed-with-exit-code-5-in-my-python-repo

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title [TEST] Trigger Build Fix DmLab tests Mar 7, 2024
@pseudo-rnd-thoughts
Copy link
Member Author

@elliottower there appears to be an issue importing dm-lab (https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336)

____________________ ERROR collecting tests/test_dm_lab.py _____________________
ImportError while importing test module '/usr/local/shimmy/tests/test_dm_lab.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_dm_lab.py:12: in <module>
    import deepmind_lab
../lib/python3.10/site-packages/deepmind_lab/__init__.py:[28](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:29): in <module>
    _deepmind_lab = imp.load_dynamic(
../lib/python3.10/imp.py:[34](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:35)3: in load_dynamic
    return _load(spec)
E   ImportError: /usr/local/lib/python3.10/site-packages/deepmind_lab/deepmind_lab.so: cannot open shared object file: No such file or directory

Not sure what the particular issue is, could you look at?

@elliottower
Copy link
Member

@elliottower there appears to be an issue importing dm-lab (https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336)

____________________ ERROR collecting tests/test_dm_lab.py _____________________
ImportError while importing test module '/usr/local/shimmy/tests/test_dm_lab.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_dm_lab.py:12: in <module>
    import deepmind_lab
../lib/python3.10/site-packages/deepmind_lab/__init__.py:[28](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:29): in <module>
    _deepmind_lab = imp.load_dynamic(
../lib/python3.10/imp.py:[34](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:35)3: in load_dynamic
    return _load(spec)
E   ImportError: /usr/local/lib/python3.10/site-packages/deepmind_lab/deepmind_lab.so: cannot open shared object file: No such file or directory

Not sure what the particular issue is, could you look at?

That’s super weird maybe we could try different versions of the dm lab package? That’s the only thing that I can imagine changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants