Fix agent indicator inf bounded spaces #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottower
reviewed
Jan 18, 2024
| return new_obs | ||
| elif ndims == 3 or ndims == 2: | ||
| obs = obs if ndims == 3 else np.expand_dims(obs, 2) | ||
| old_shaped3 = obs.shape[2] | ||
| new_obs = np.pad(obs, [(0, 0), (0, 0), (0, num_indicators)]) | ||
| new_obs[:, :, old_shaped3 + indicator_num] = np.min(space.high) |
There was a problem hiding this comment.
My only question @KaleabTessera is why was the code previously np.min(space.high) whereas now it is np.max(space.high), would this not mean different behavior?
There was a problem hiding this comment.
I'm going to trust your tests ensure this behavior is correct and make a release because I need to today for something else, if this ends up being a bug we can do a hotfix release fixing it though
There was a problem hiding this comment.
Have this same question too, would like a clarification. I'm guessing it makes it easier for RL agents to see the indicator if they internally normalize observation, but this would change behaviour of all agents downstream.
elliottower
reviewed
Jan 18, 2024
elliottower
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the agent indicator so that it works with envs that have unbounded spaces (space.high=np.inf) e.g. simple spread.
Closes #239.