Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path issue with conditional files on Windows #7

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Fix path issue with conditional files on Windows #7

merged 11 commits into from
Oct 16, 2024

Conversation

kir0ul
Copy link
Contributor

@kir0ul kir0ul commented Oct 16, 2024

Description

This PR fixes a path error using Copier with conditional files on Windows, see https://github.com/orgs/copier-org/discussions/1695 for the solution.

Fixes #6.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • My changes generate no new warnings
  • I have added CI jobs for Windows and macOS that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kir0ul kir0ul mentioned this pull request Oct 16, 2024
Closed
1 task
pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @kir0ul

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 052456f into Farama-Foundation:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] jinja error
2 participants
@kir0ul @pseudo-rnd-thoughts