Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gymnasium 1.0 support #89

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

ppasupat
Copy link
Collaborator

@ppasupat ppasupat commented Feb 28, 2024

Description

  • Updated import to work without the removed plugin system.
  • Updated README and the documentation
  • Updated the import for wrappers.
  • Updated the dependency to gymnasium>=1.0.0a1.
  • Bumped the version number of the package itself from 1.0 --> 1.0.1

Fixes #88

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks @ppasupat for the quick PR.
I'm glad that no significant changes were required.
Until v1.0.0 is released, I wouldn't make a new MiniWOB++ release unless necessary

@ppasupat
Copy link
Collaborator Author

@pseudo-rnd-thoughts Thank you.

Until v1.0.0 is released, I wouldn't make a new MiniWOB++ release unless necessary

Should I revert the version number in miniwob/__init__.py back to 1.0? Or is this about making a Release on GitHub?

@pseudo-rnd-thoughts
Copy link
Member

Should I revert the version number in miniwob/init.py back to 1.0? Or is this about making a Release on GitHub?

Sorry, yes, this is about making a release on github

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 1bab0df into Farama-Foundation:master Mar 1, 2024
5 checks passed
@ppasupat ppasupat deleted the gym1.0.0a1 branch March 5, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Update Gymnasium to v1.0.0a1
2 participants