Extend IG with reward modes, make terms uniform across IG and BPD #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffelten
reviewed
May 29, 2024
| sections, | ||
| capacity, | ||
| type_distribution, | ||
| position_distribution, | ||
| render_mode, | ||
| ) | ||
| self.reward_scheme = reward_scheme | ||
| if reward_mode not in ["individual", "team"]: | ||
| self.reward_mode = "individual" |
There was a problem hiding this comment.
Why don't we throw an exception in that case?
There was a problem hiding this comment.
Changed in the meantime to throw a warning and fall back on the individual setting.
ffelten
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend IG with reward modes, correct descriptions, make terms uniform across IG and BPD (reward mode instead of scheme, individual/team instead of local/global).