Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item gathering added to main #6

Merged
merged 31 commits into from
Nov 7, 2023
Merged

Item gathering added to main #6

merged 31 commits into from
Nov 7, 2023

Conversation

rradules
Copy link
Collaborator

The implementation of the MO-Item gathering environment based on the environment from:

Johan Källström and Fredrik Heintz. 2019. Tunable Dynamics in Agent-Based Simulation using Multi-Objective
Reinforcement Learning. Presented at the Adaptive and Learning Agents Workshop at AAMAS 2019.
https://liu.diva-portal.org/smash/record.jsf?pid=diva2%3A1362933&dswid=9018

@rradules rradules closed this Oct 20, 2023
@rradules rradules reopened this Oct 20, 2023
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one :-).
My main worry is essentially the divergence with the original env. We can discuss that later today.

momadm_benchmarks/envs/item_gathering/__init__.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/item_gathering/item_gathering.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/item_gathering/item_gathering.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/item_gathering/item_gathering.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/item_gathering/item_gathering.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/item_gathering/item_gathering.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/item_gathering/item_gathering.py Outdated Show resolved Hide resolved
# Apply actions and update system state
for i, agent in enumerate(self.agents):
act = actions[agent]
print(agent, ACTIONS[act])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup prints :-)

momadm_benchmarks/tester_itemgathering.py Outdated Show resolved Hide resolved
@rradules rradules requested a review from ffelten October 30, 2023 14:12
Copy link
Collaborator Author

@rradules rradules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I made all the updates. Biggest change is adding functionality to generate random maps and randomise maps, according to the original paper. I also added additional notes on how our observation space is different than the original implementation.

@rradules rradules removed the request for review from Tuireann October 31, 2023 11:13
@rradules rradules removed request for wilrop and ffelten November 7, 2023 10:33
@rradules rradules merged commit 6bb6ef6 into main Nov 7, 2023
5 checks passed
@rradules rradules deleted the item-gathering branch November 7, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants