Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crazyrl/surround implemented #7

Merged
merged 19 commits into from
Nov 2, 2023
Merged

crazyrl/surround implemented #7

merged 19 commits into from
Nov 2, 2023

Conversation

umutucak
Copy link
Collaborator

No description provided.

@umutucak umutucak requested a review from ffelten October 23, 2023 09:54
@umutucak
Copy link
Collaborator Author

Below is the rewards printing for MO and SO
image

@umutucak umutucak removed the request for review from ffelten October 23, 2023 13:06
@umutucak umutucak closed this Oct 24, 2023
@umutucak umutucak reopened this Oct 24, 2023
@umutucak umutucak requested a review from ffelten October 24, 2023 13:53
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to add opengl to the pyproject ?

momadm_benchmarks/envs/crazyrl/catch/catch.py Show resolved Hide resolved
momadm_benchmarks/envs/crazyrl/catch/catch.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/crazyrl/catch/catch.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/crazyrl/catch/catch.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/crazyrl/catch/catch.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/crazyrl/crazyRL_base.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/crazyrl/crazyRL_base.py Outdated Show resolved Hide resolved
momadm_benchmarks/utils/conversions.py Outdated Show resolved Hide resolved
@umutucak
Copy link
Collaborator Author

umutucak commented Oct 26, 2023

@ffelten the obs/act/rew spaces currently take the agent as a parameter (see fun _reward_space())but do not return a space specific to that agent but rather the general space. should I remove the agent parameter or try to make them agent specific?

I think they can remain general as they have the same goals for these 3 environments

@ffelten
Copy link
Collaborator

ffelten commented Oct 26, 2023

@ffelten the obs/act/rew spaces currently take the agent as a parameter (see fun _reward_space())but do not return a space specific to that agent but rather the general space. should I remove the agent parameter or try to make them agent specific?

I think they can remain general as they have the same goals for these 3 environments

I think it is the API of PZ which asks for an agent, isn't it? :-)

@umutucak umutucak requested a review from ffelten October 26, 2023 14:26
@umutucak
Copy link
Collaborator Author

Did you forget to add opengl to the pyproject ?

I made the change in the main branch

momadm_benchmarks/envs/crazyrl/crazyRL_base.py Outdated Show resolved Hide resolved
self.agent_location = self.init_flying_pos.copy()

# targets
self.init_target_location = {"unique": init_target_location} # unique target location for all agents
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be converted to a flat variable instead of a dictionary as in all envs we have only one target

momadm_benchmarks/envs/crazyrl/crazyRL_base.py Outdated Show resolved Hide resolved
momadm_benchmarks/envs/crazyrl/crazyRL_base.py Outdated Show resolved Hide resolved
momadm_benchmarks/utils/all_modules.py Show resolved Hide resolved
@umutucak umutucak requested a review from ffelten November 2, 2023 10:24
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@ffelten ffelten merged commit 47b171b into main Nov 2, 2023
5 checks passed
@ffelten ffelten deleted the crazyrl branch November 2, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants