feat(fd2): adds entry point for soil disturbance events

[sidlamsal]

Pull Request Description

Adds:

• soil disturbance entry point
• lib.js including tests
• e2e tests

Closes #249

---

Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

Co-authored-by: Shahir Ahmed [email protected]

[braughtg]

I have only looked at the getPlantAssets function so far. There are a few suggestions in the code.

[braughtg]

Getting really close. See the embedded comments for a few issues.

[braughtg]

Some prior tests change the database in ways that can make this test fail. So we just need to ensure that the database is reset before the soil_disturbance/submission.e2e.cy.js test is run. You can do this by adding the following before hook in that test:

  before(() => {
    cy.task('initDB');
  });

[braughtg]

When manually testing the Soil Disturbance endpoint I noticed a few things:

• The comment is not being added to the Activity Logs that are created. The comment provided should be added to the log for each pass.
• The Area (%) is not updated based upon the beds that are selected. For example, if 2/4 beds are selected then the Area (%) should default to 50% of the area and allow the user to adapt it from there.

One other small improvement that I think we should make is:

• when there are multiple passes, add "Pass 1." or "Pass 2.", etc to the beginning of the comment for each log.

The tests should be also be augmented to check for these things.

[braughtg]

Everything looks good. Just one request for a small test change since farmosUtil.js was also modified here.

[github-actions]

🎉 This PR is included in version 1.4.0-development.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀