Prefer RGBA over CI toggle for automatic texture format

[Lilaa3]

Suggested by a ton of people.
Kinda of inconvenient for people who care about performance but with repo settings files (see settings rework pr) it will be no issue for anyone who cares.

[jesusyoshi54]

def getOptimalFormat(tex, curFormat, isMultitexture):
    texFormat = "RGBA16"
    if isMultitexture:
        return curFormat

link

If you are adding a multi-texture, and one texture is already set, the optimal texture format of the second one is curFormat unless the other texture is in opposition to the current format, in which case the optimal format is CI or whatever this function returns.

A CI multi-texture must use another CI texture and likewise an RGBA/Intensity texture must NOT use a CI texture.

I would also say that it is best if when choosing a new texture in a multi-texture, that it optimally chose the correct format between available options. If I swap between a color or intensity option, I would prefer if the texture format automatically updated. The only restriction is that I can't use a CI.

[Lilaa3]

If you are adding a multi-texture, and one texture is already set, the optimal texture format of the second one is curFormat

Wait why?? curFormat is just the format of the not updated texture format

[jesusyoshi54]

Wait why?? curFormat is just the format of the not updated texture format

Currently it returns curFormat universally while making a multi-texture. This is fine but not under the circumstances I laid out before.
On top of that I think you could also just run the format change as needed but just exclude CI or non CI textures as needed.

I said optimal but really it isn't per se, I more meant that it was a valid return.

[Dragorn421]

Is this PR waiting on anything? (for what specifically?)

If just waiting for lila to answer np I don't mean to rush you. Just want to make sure we're not in a confusingly-waiting-each-other deadlock scenario

also bump again for the prefer_ci_over_rgba default

[jesusyoshi54]

Shouldn't the prefer_ci_over_rgba prop be UI dependent on auto_pick_texture_format prop? Maybe having it dynamic kind of sucks idk. I feel like there should be a UI connection of the props though

[Lilaa3]

Shouldn't the prefer_ci_over_rgba prop be UI dependent on auto_pick_texture_format prop? Maybe having it dynamic kind of sucks idk. I feel like there should be a UI connection of the props though

Oh yeah good call

[Lilaa3]

Is there anything else missing @jesusyoshi54 ?

[jesusyoshi54]

Is there anything else missing @jesusyoshi54 ?

I'll review tonight. First glance looks good

[jesusyoshi54]

Ok this is very nice I like a lot good job lila you are the best