[OoT] Refactor spec.py
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just have newline issues left, otherwise it should be ready (keeping as a draft while this is not fixed) |
Yanis002
added
oot
Merged
|
ok well, no idea where the newline issues comes from (also it's a kind of edge case tbh), I'll try to see if there's more concerning issues otherwise I'll mark it ready to review |
sauraen
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the recent issues with decomp and it should prevent future breaks, there's 2 things I need to do but I wanted to PR this anyway so I'm just gonna make it a draft
this PR is in the same spirit as #272, with this spec refactor you can copy paste everything (except
editSpecFile) somewhere else, callSpecFileand use this as a standalone scriptalso this is a fix for #305 and the other issue HackerOoT has with ifdefs