Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create black-suggest.yml #455

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

coco875
Copy link
Contributor

@coco875 coco875 commented Sep 11, 2024

will suggest what black found wrong automatically.

@coco875
Copy link
Contributor Author

coco875 commented Sep 11, 2024

I will make an example of PR later, but also don't know if it's useful because black are pretty easy to install and are easy to format with it

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Sep 11, 2024

Not an expert on github actions but shouldn't you be using our specific version of black? the check is failing

@coco875
Copy link
Contributor Author

coco875 commented Sep 11, 2024

The fail is because of I don't setup the install correctly and will try to do how your action do

@coco875
Copy link
Contributor Author

coco875 commented Sep 11, 2024

Ok can't because he use the source directly but I will hard code the version That you use

@coco875
Copy link
Contributor Author

coco875 commented Sep 11, 2024

example coco875#1

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Sep 11, 2024

@Dragorn421 I think this could be neat, didn't you have to black format for reonu just a while ago?

@coco875
Copy link
Contributor Author

coco875 commented Sep 11, 2024

(I can also make an action who will PR black format when he detect it)

@Dragorn421
Copy link
Contributor

This is neat
Is there a way to combine the two github actions in one? Both the lint check and suggestions are doing the same thing (black formatting)

@coco875
Copy link
Contributor Author

coco875 commented Sep 12, 2024

in one file or in one job ?

@coco875
Copy link
Contributor Author

coco875 commented Sep 12, 2024

and black format suggestion need to be trigger only for pull request not for push so it will be even hard to combine in one file

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Oct 27, 2024

I don´t know how this could be merged into a single action, don´t see anything on the docs. Is it possible to check if there was a difference and use that to block merging? @coco875
It would also need to check if black . didn't fail for this!
(I'll try to help but I can't promise much since I'm still learning these)

@Lilaa3 Lilaa3 requested a review from Dragorn421 October 28, 2024 10:51
@Lilaa3
Copy link
Collaborator

Lilaa3 commented Oct 28, 2024

I tried to help coco implement a single job for both formatting suggestion and linting, see if you like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants