-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create black-suggest.yml #455
base: main
Are you sure you want to change the base?
Conversation
I will make an example of PR later, but also don't know if it's useful because black are pretty easy to install and are easy to format with it |
Not an expert on github actions but shouldn't you be using our specific version of black? the check is failing |
The fail is because of I don't setup the install correctly and will try to do how your action do |
Ok can't because he use the source directly but I will hard code the version That you use |
example coco875#1 |
@Dragorn421 I think this could be neat, didn't you have to black format for reonu just a while ago? |
(I can also make an action who will PR black format when he detect it) |
This is neat |
in one file or in one job ? |
and black format suggestion need to be trigger only for pull request not for push so it will be even hard to combine in one file |
I don´t know how this could be merged into a single action, don´t see anything on the docs. Is it possible to check if there was a difference and use that to block merging? @coco875 |
Single action and fix for forks
I tried to help coco implement a single job for both formatting suggestion and linting, see if you like it! |
will suggest what black found wrong automatically.