Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F3D] Backport point lit ucode from AC pr #460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Sep 15, 2024

internal_game_update_ver now checks for less than 2, we need to update defaults again lol

Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't explain it but loading a blend that has F3DEX3 set as ucode (scene.f3d_type) with this branch, sets the ucode to F3DEX2
It must have something to do with the enumF3D change but idk

What's the reasoning for setting the world defaults for positional lighting to true for oot and sm64 when they don't use it in the first place?

fast64_internal/f3d/f3d_material.py Outdated Show resolved Hide resolved
Co-Authored-By: Dragorn421 <[email protected]>
@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Oct 9, 2024

I can't explain it but loading a blend that has F3DEX3 set as ucode (scene.f3d_type) with this branch, sets the ucode to
F3DEX2 It must have something to do with the enumF3D change but idk

Going to look at that, shouldn't be happening?

What's the reasoning for setting the world defaults for positional lighting to true for oot and sm64 when they don't use it in the first place?

If you're using a point lit ucode in your repo that is most likely how you are implementing it, that's the case for sm64 ligthing engine for example

@Dragorn421 Dragorn421 added enhancement New feature or request f3d Has to do with the "f3d" code common to all games labels Oct 9, 2024
@Lilaa3 Lilaa3 requested a review from Dragorn421 October 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request f3d Has to do with the "f3d" code common to all games
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants