Merge pull request #1 from FastLane-Labs/fix-test

fix: declare `path` and `solverOps` arrays in test

.github/workflows/test.yml

@@ -11,7 +11,7 @@ env:
 jobs:
   check:
     strategy:
-      fail-fast: true
+      fail-fast: false
 
     name: Foundry project
     runs-on: ubuntu-latest
@@ -23,7 +23,7 @@ jobs:
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
         with:
-          version: nightly
+          version: nightly-0d8302880b79fa9c3c4aa52ab446583dece19a34 # 2024-08-29 release
 
       - name: Show Forge version
         run: |
@@ -36,10 +36,12 @@ jobs:
 
       - name: Run Forge build
         run: |
-          forge build --sizes
+          forge build
         id: build
 
       - name: Run Forge tests
         run: |
           forge test -vvv
+        env:
+          MAINNET_RPC_URL: ${{ secrets.MAINNET_RPC_URL }}
         id: test

foundry.toml

@@ -17,6 +17,7 @@
 [profile.ci]
   fuzz = { runs = 10_000 }
   verbosity = 2
+  ignore_warnings = true
 
 [fmt]
   bracket_spacing = true

remappings.txt

@@ -1,6 +1,5 @@
 forge-std/=lib/forge-std/src/
 @atlas/=lib/atlas/src/contracts/
 @atlas-test/=lib/atlas/test/
-openzeppelin-contracts-upgradeable/=lib/openzeppelin-contracts-upgradeable/
 openzeppelin-contracts/=lib/openzeppelin-contracts/
 solady/=lib/solady/src/

src/UniswapV2DAppControl.sol

@@ -12,7 +12,7 @@ import { UserOperation } from "@atlas/types/UserOperation.sol";
 import { SolverOperation } from "@atlas/types/SolverOperation.sol";
 
 // Uniswap Imports
-import { IUniswapV2Router01, IUniswapV2Router02 } from "src/interfaces/IUniswapV2Router.sol";
+import { IUniswapV2Router01, IUniswapV2Router02 } from "./interfaces/IUniswapV2Router.sol";
 
 /*
 * @title UniswapV2DAppControl

test/UniswapV2DAppControl.t.sol

@@ -19,8 +19,8 @@ import { BaseTest } from "@atlas-test/base/BaseTest.t.sol";
 import { AccountingMath } from "@atlas/libraries/AccountingMath.sol";
 
 // Import the contract under test and related Uniswap V2 router interfaces
-import { UniswapV2DAppControl } from "src/UniswapV2DAppControl.sol";
-import { IUniswapV2Router01, IUniswapV2Router02 } from "src/interfaces/IUniswapV2Router.sol";
+import { UniswapV2DAppControl } from "../src/UniswapV2DAppControl.sol";
+import { IUniswapV2Router01, IUniswapV2Router02 } from "../src/interfaces/IUniswapV2Router.sol";
 
 // Import helper contracts for building transactions during testing
 import { TxBuilder } from "@atlas/helpers/TxBuilder.sol";
@@ -77,7 +77,7 @@ contract UniswapV2DAppControlTest is BaseTest {
     function test_UniswapV2DAppControl_swapWETHForDAI() public {
         // Initialize structures to hold user and solver operations as well as DApp operation details.
         UserOperation memory userOp;
-        SolverOperation;
+        SolverOperation[] memory solverOps = new SolverOperation[](1);
         DAppOperation memory dAppOp;
 
         // ===========================
@@ -98,7 +98,7 @@ contract UniswapV2DAppControlTest is BaseTest {
         vm.label(address(executionEnvironment), "EXECUTION ENV");
 
         // Define the token swap path for Uniswap V2: from WETH to DAI.
-        address;
+        address[] memory path = new address[](2);
         path[0] = WETH_ADDRESS; // Starting token: Wrapped ETH
         path[1] = DAI_ADDRESS; // Target token: DAI