Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/hooks access to all parameter #25

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Refactor/hooks access to all parameter #25

merged 8 commits into from
Oct 29, 2024

Conversation

0x1NotMe
Copy link
Contributor

@0x1NotMe 0x1NotMe commented Oct 9, 2024 •
edited
Loading

Changes:

  • add explicit chainId to arguments for each function
  • pass all arguments to the preHook (allows overwrite of extra, wait)
  • pass chainId and extra to postHook (access to extra and chainId)

Refactor:

Fastlane Backend Implementation

  • introduce a new class to consolidate duplicated logic to build the request
  • add fastlane backend tests

Fix:

  • fixed encoding issue for bigInt (use hex strings over strings)
  • fixed issue with solverBuilder not passing the operations correctly to constructor

@0x1NotMe 0x1NotMe requested a review from jj1980a October 9, 2024 06:44
jj1980a
jj1980a approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jj1980a jj1980a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0x1NotMe 0x1NotMe force-pushed the refactor/hooks-access-to-all-parameter branch from 0edfabd to 2c0a453 Compare October 11, 2024 05:13
@0x1NotMe 0x1NotMe force-pushed the refactor/hooks-access-to-all-parameter branch from 2c0a453 to 61491ce Compare October 29, 2024 00:31
@0x1NotMe 0x1NotMe merged commit a39b0ab into main Oct 29, 2024
1 check passed
@0x1NotMe 0x1NotMe deleted the refactor/hooks-access-to-all-parameter branch October 29, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jj1980a jj1980a jj1980a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x1NotMe @jj1980a