Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executeOnLoss #21

Merged
merged 5 commits into from
Jan 24, 2024
Merged

executeOnLoss #21

merged 5 commits into from
Jan 24, 2024

Conversation

thogard785
Copy link
Collaborator

added executeOnLoss boolean flag to submitFastBid that will enable searchers to execute their transactions even if they lose the auction

…archers to execute their transactions even if they lose the auction
Copy link
Contributor

@BenSparksCode BenSparksCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Same note as in #20, if we set solc = 0.8.20, we should set EVM version to Paris, because Polygon PoS does not support PUSH0. I have not added that change here as it is already added in #20

@thogard785 thogard785 merged commit 6d94920 into main Jan 24, 2024
1 check passed
@thogard785 thogard785 deleted the unconditionally-execute branch January 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants