Address some issues found by sonarcloud

Fastcode · Sep 16, 2023 · 21b6096 · 21b6096
1 parent 0b78e29
commit 21b6096
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/src/dsl/operation/ChronoTask.hpp b/src/dsl/operation/ChronoTask.hpp
@@ -47,7 +47,7 @@ namespace dsl {
             ChronoTask(std::function<bool(NUClear::clock::time_point&)>&& task,
                        NUClear::clock::time_point time,
                        uint64_t id)
-                : task(task), time(time), id(id) {}
+                : task(std::move(task)), time(time), id(id) {}
 
             /**
              * @brief Run the task and return true if the time has been updated to run again

diff --git a/src/dsl/word/Last.hpp b/src/dsl/word/Last.hpp
@@ -36,7 +36,7 @@ namespace dsl {
 
             LastItemStorage() : list() {}
 
-            LastItemStorage(T&& data) : list({data}) {}
+            LastItemStorage(T&& data) : list({std::move(data)}) {}
 
             template <typename Output>
             operator std::list<Output>() const {

diff --git a/src/dsl/word/Network.hpp b/src/dsl/word/Network.hpp
@@ -34,7 +34,7 @@ namespace dsl {
             NetworkData() : std::shared_ptr<T>() {}
             NetworkData(T* ptr) : std::shared_ptr<T>(ptr) {}
             NetworkData(const std::shared_ptr<T>& ptr) : std::shared_ptr<T>(ptr) {}
-            NetworkData(std::shared_ptr<T>&& ptr) : std::shared_ptr<T>(ptr) {}
+            NetworkData(std::shared_ptr<T>&& ptr) : std::shared_ptr<T>(std::move(ptr)) {}
         };
 
         struct NetworkSource {

diff --git a/src/threading/Reaction.cpp b/src/threading/Reaction.cpp
@@ -24,7 +24,10 @@ namespace threading {
     std::atomic<uint64_t> Reaction::reaction_id_source(0);  // NOLINT
 
     Reaction::Reaction(Reactor& reactor, ReactionIdentifiers&& identifiers, TaskGenerator&& generator)
-        : reactor(reactor), identifiers(identifiers), id(++reaction_id_source), generator(generator) {}
+        : reactor(reactor)
+        , identifiers(std::move(identifiers))
+        , id(++reaction_id_source)
+        , generator(std::move(generator)) {}
 
     void Reaction::unbind() {
         // Unbind

diff --git a/src/threading/ReactionTask.hpp b/src/threading/ReactionTask.hpp
@@ -93,7 +93,7 @@ namespace threading {
             , emit_stats(parent.emit_stats && (current_task != nullptr ? current_task->emit_stats : true))
             , group_descriptor(group_descriptor)
             , thread_pool_descriptor(thread_pool_descriptor)
-            , callback(callback) {}
+            , callback(std::move(callback)) {}
 
 
         /**