New clang-tidy things

Fastcode · Aug 9, 2024 · 6cd5848 · 6cd5848
1 parent 26b917b
commit 6cd5848
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 5 deletions.
diff --git a/src/threading/ReactionHandle.cpp b/src/threading/ReactionHandle.cpp
@@ -22,6 +22,10 @@
 
 #include "ReactionHandle.hpp"
 
+#include <memory>
+
+#include "Reaction.hpp"
+
 namespace NUClear {
 namespace threading {
 

diff --git a/src/threading/scheduler/CombinedLock.cpp b/src/threading/scheduler/CombinedLock.cpp
@@ -21,6 +21,10 @@
  */
 #include "CombinedLock.hpp"
 
+#include <memory>
+#include <thread>
+#include <utility>
+
 namespace NUClear {
 namespace threading {
     namespace scheduler {

diff --git a/src/threading/scheduler/CountingLock.cpp b/src/threading/scheduler/CountingLock.cpp
@@ -22,7 +22,6 @@
 #include "CountingLock.hpp"
 
 #include <atomic>
-#include <utility>
 
 namespace NUClear {
 namespace threading {

diff --git a/src/util/FileDescriptor.cpp b/src/util/FileDescriptor.cpp
@@ -22,6 +22,7 @@
 
 #include "FileDescriptor.hpp"
 
+#include <functional>
 #include <utility>
 
 #include "platform.hpp"

diff --git a/src/util/Sleeper.cpp b/src/util/Sleeper.cpp
@@ -22,7 +22,6 @@
 
 #include "Sleeper.hpp"
 
-#include <array>
 #include <chrono>
 
 #if defined(_WIN32)
@@ -63,7 +62,6 @@ namespace util {
 #else
 
     #include <cerrno>
-    #include <cstdint>
     #include <ctime>
 
 namespace NUClear {

diff --git a/src/util/main_thread_id.cpp b/src/util/main_thread_id.cpp
@@ -22,6 +22,8 @@
 
 #include "main_thread_id.hpp"
 
+#include <thread>
+
 namespace NUClear {
 namespace util {
 

diff --git a/src/util/network/resolve.cpp b/src/util/network/resolve.cpp
@@ -22,12 +22,15 @@
 
 #include "resolve.hpp"
 
+#include <cstdint>
 #include <cstring>
 #include <memory>
 #include <stdexcept>
+#include <string>
 #include <system_error>
 
 #include "../platform.hpp"
+#include "sock_t.hpp"
 
 namespace NUClear {
 namespace util {

diff --git a/src/util/network/sock_t.hpp b/src/util/network/sock_t.hpp
@@ -40,7 +40,7 @@ namespace util {
                 sockaddr_in6 ipv6;
             };
 
-            inline socklen_t size() const {
+            socklen_t size() const {
                 switch (sock.sa_family) {
                     case AF_INET: return sizeof(sockaddr_in);
                     case AF_INET6: return sizeof(sockaddr_in6);
@@ -50,7 +50,7 @@ namespace util {
                 }
             }
 
-            inline std::pair<std::string, in_port_t> address() const {
+            std::pair<std::string, in_port_t> address() const {
                 std::array<char, std::max(INET_ADDRSTRLEN, INET6_ADDRSTRLEN)> c = {0};
                 switch (sock.sa_family) {
                     case AF_INET:

diff --git a/src/util/serialise/xxhash.cpp b/src/util/serialise/xxhash.cpp
@@ -22,6 +22,7 @@
 
 #include "xxhash.hpp"
 
+#include <cstdint>
 #include <type_traits>
 
 namespace NUClear {