Add a unit test that for when a pool is blocked with no tasks #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrentHouliston
added a commit
that referenced
this pull request
Aug 21, 2024
The old scheduler had the possiblity of a deadlock when two of the threads came in and tried to acquire the idle and pool mutexes at the same time. This scheduler has rearranged parts of the locks to ensure that deadlocks don't happen. As a side effect should also fix the issue raised in #109 A feature which has come about as a result is that tasks may belong to multiple sync groups at once
TrentHouliston
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there exists a bug where if all threads in a pool can't execute due to being blocked by a group, they will sleep forever
For now this PR only has a test that identifies the issue until a fix is found