Upgrade clang-tidy to version 19 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrentHouliston
changed the title
TrentHouliston
changed the title
They are mostly ensuring that IWYU is followed and ensuring functions that are only used in a cpp file they have internal linkage. However there are also a few instances of ensuring the CRTP classes are used as CRTP, and one issue that was found where a type was being forwarded twice (potentially moving data when it shouldn't)
… work I'm just turning off the include cleaner until it's more mature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading clang-tidy to version 19 as well as using ubuntu 24.04 for the GHA runners