Refactor tests to use an event style and fix some found bugs

.github/workflows/main.yaml

@@ -24,7 +24,8 @@ jobs:
 
     strategy:
       matrix:
-        container: ['gcc:5', 'gcc:7', 'gcc:9', 'gcc:10', 'gcc:11', 'gcc:12', 'gcc:13']
+        container:
+          ["gcc:5", "gcc:7", "gcc:9", "gcc:10", "gcc:11", "gcc:12", "gcc:13"]
 
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
@@ -33,9 +34,7 @@ jobs:
     # Use the container for this specific version of gcc
     container: ${{ matrix.container }}
 
-    # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - name: Checkout Code
         uses: actions/checkout@v3
 
@@ -57,7 +56,7 @@ jobs:
         run: cmake --build build --config Release --parallel 2
 
       - name: Test
-        timeout-minutes: 5
+        timeout-minutes: 10
         # Execute tests defined by the CMake configuration.
         # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
         run: |
@@ -66,13 +65,9 @@ jobs:
 
   build-osx:
     name: MacOS Clang
-
-    # The type of runner that the job will run on
     runs-on: macos-latest
 
-    # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - name: Checkout Code
         uses: actions/checkout@v3
 
@@ -87,7 +82,7 @@ jobs:
         run: cmake --build build --config Release --parallel 2
 
       - name: Test
-        timeout-minutes: 5
+        timeout-minutes: 10
         # Execute tests defined by the CMake configuration.
         # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
         run: |
@@ -100,9 +95,7 @@ jobs:
     # The type of runner that the job will run on
     runs-on: windows-latest
 
-    # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - name: Checkout Code
         uses: actions/checkout@v3
 
@@ -117,7 +110,7 @@ jobs:
         run: cmake --build build --config Release --parallel 2
 
       - name: Test
-        timeout-minutes: 5
+        timeout-minutes: 10
         # Execute tests defined by the CMake configuration.
         # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
         run: |
@@ -127,21 +120,17 @@ jobs:
 
   check-clang-tidy-linux:
     name: Clang-Tidy Linux
-
-    # The type of runner that the job will run on
     runs-on: ubuntu-latest
 
-    # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
       - name: Install clang-tidy-15
         run: |
-         wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
-         echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-15 main" | sudo tee /etc/apt/sources.list.d/llvm-15
-         echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-15 main" | sudo tee -a /etc/apt/sources.list.d/llvm-15
-         sudo apt-get update
-         sudo apt-get install -y clang-tidy-15
+          wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
+          echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-15 main" | sudo tee /etc/apt/sources.list.d/llvm-15
+          echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-15 main" | sudo tee -a /etc/apt/sources.list.d/llvm-15
+          sudo apt-get update
+          sudo apt-get install -y clang-tidy-15
 
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - name: Checkout Code
         uses: actions/checkout@v3
 
@@ -164,13 +153,9 @@ jobs:
 
   check-clang-tidy-msvc:
     name: Clang-Tidy MSVC
-
-    # The type of runner that the job will run on
     runs-on: windows-latest
 
-    # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - name: Checkout Code
         uses: actions/checkout@v3
 

CMakeLists.txt

@@ -13,9 +13,15 @@
 # WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 # COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
 # OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
 cmake_minimum_required(VERSION 3.15.0)
 
+# Set the project after the build type as the Project command can change the build type
+project(
+  NUClear
+  VERSION 1.0.0
+  LANGUAGES C CXX
+)
+
 # We use additional modules that cmake needs to know about
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/Modules/")
 
@@ -35,13 +41,6 @@ if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
   set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS "Debug" "Release" "MinSizeRel" "RelWithDebInfo")
 endif()
 
-# Set the project after the build type as the Project command can change the build type
-project(
-  NUClear
-  VERSION 1.0.0
-  LANGUAGES C CXX
-)
-
 # NUClear targets c++14
 set(CMAKE_CXX_STANDARD 14)
 
@@ -51,6 +50,12 @@ if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
   set(MASTER_PROJECT ON)
 endif()
 
+if(MSVC)
+  add_compile_options(/W4)
+else()
+  add_compile_options(-Wall -Wextra -pedantic)
+endif(MSVC)
+
 # If this option is set we are building using continous integration
 option(CI_BUILD "Enable build options for building in the CI server" OFF)
 

src/dsl/word/TCP.hpp

@@ -94,9 +94,8 @@ namespace dsl {
                                                            in_port_t port                  = 0,
                                                            const std::string& bind_address = "") {
 
-                // Make our socket
-                util::FileDescriptor fd(::socket(AF_INET, SOCK_STREAM, IPPROTO_TCP),
-                                        [](fd_t fd) { ::shutdown(fd, SHUT_RDWR); });
+                // Resolve the bind address if we have one
+                util::network::sock_t address{};
 
                 if (!bind_address.empty()) {
                     address = util::network::resolve(bind_address, port);