Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NUClear logs always emit #91

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Make NUClear logs always emit #91

merged 3 commits into from
Sep 25, 2023

Conversation

TrentHouliston
Copy link
Member

For many log handlers, the display level is important as only the logs you want to view should be displayed.
This display level has been typically set using the log level in each reactor and nuclear has filtered out logs below the display level from reaching the log handlers.
However, some log handlers are able to store and process logs more intelligently and make them available to access beyond their set display level.

Copy link
Contributor

@Bidski Bidski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrentHouliston TrentHouliston enabled auto-merge (squash) September 25, 2023 00:28
@TrentHouliston TrentHouliston merged commit 2fbf7e3 into main Sep 25, 2023
15 checks passed
@TrentHouliston TrentHouliston deleted the houliston/alllogs branch September 25, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants