-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call the right filterFinishArray()
/filterFinishObject()
from FilteringParserDelegate
#1111
Call the right filterFinishArray()
/filterFinishObject()
from FilteringParserDelegate
#1111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dmikurube First of all, thank you for this contribution! Always great to get a bug report AND matching fix. Second, yes, 2.15 is fine since this looks like very safe fix (low likelihood of regression). I can then merge it forward to 2.16. Third: one formality before I can merge this in: I need a CLA (from https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf) -- it's one-pager and only needs to be sent once before the first contribution, works for all future contributions. Thank you once again for the fix! |
Thanks, @cowtowncoder! Yeah, sorry to be late. I sent my CLA just now. |
CLA received, will merge. |
filterFinishArray()
/filterFinishObject()
from FilteringParserDelegate
Thanks! |
Hi,
While I was tackling https://groups.google.com/g/jackson-user/c/bLZTjjjXZ28 , I found that
filterFinishObject
is not called properly under some condition.filterFinishArray
is called against"}"
instead offilterFinishObject
.The first commit is a new test to confirm this behavior (the added test should fail before the second commit), and the second commit fixes the issue.
I created this pull request against
2.15
because https://github.com/FasterXML/jackson/blob/master/CONTRIBUTING.md says :(but "the current stable branch" may be now
2.15
, not2.14
?)Please tell me if another branch should be the base.
I have not signed/sent the CLA yet. I'll do it in a couple of days.