Update release notes wrt #3647 fix

FasterXML · Oct 1, 2023 · 8328baf · 8328baf
1 parent ae77a0c
commit 8328baf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/release-notes/VERSION-2.x b/release-notes/VERSION-2.x
@@ -10,6 +10,9 @@ Project: jackson-databind
  (contributed by Joo-Hyuk K)
 #2787: Mix-ins do not work for `Enum`s
  (fix contributed by Joo-Hyuk K)
+#3647: `@JsonIgnoreProperties` not working with `@JsonValue`
+ (reported by @ThatSneakyRaccoon)
+ (fix contributed by Joo-Hyuk K)
 #3780: Deprecated JsonNode.with(String) suggests using JsonNode.withObject(String)
   but it is not the same thing
  (reported by @bmatasar)

diff --git a/src/main/java/com/fasterxml/jackson/databind/ser/std/JsonValueSerializer.java b/src/main/java/com/fasterxml/jackson/databind/ser/std/JsonValueSerializer.java
@@ -455,14 +455,15 @@ protected JsonSerializer<Object> _findDynamicSerializer(SerializerProvider ctxt,
      * @return Configured serializer with specified properties ignored
      * @since 2.16
      */
-    private JsonSerializer<?> _withIgnoreProperties(SerializerProvider ctxt, JsonSerializer<?> ser) {
-        final AnnotationIntrospector ai = ctxt.getAnnotationIntrospector();
-        final SerializationConfig config = ctxt.getConfig();
-
-        JsonIgnoreProperties.Value ignorals = ai.findPropertyIgnoralByName(config, _accessor);
+    @SuppressWarnings("unchecked")
+    protected JsonSerializer<Object> _withIgnoreProperties(SerializerProvider ctxt, JsonSerializer<?> ser) {
+        JsonIgnoreProperties.Value ignorals = ctxt.getAnnotationIntrospector()
+                .findPropertyIgnoralByName(ctxt.getConfig(), _accessor);
         Set<String> ignored = ignorals.findIgnoredForSerialization();
-        ser = ser.withIgnoredProperties(ignored);
-        return ser;
+        if (!ignored.isEmpty()) {
+            ser = ser.withIgnoredProperties(ignored);
+        }
+        return (JsonSerializer<Object>) ser;
     }
 
     /*