Removed unnecessary assignments

FasterXML · Aug 26, 2023 · d48f9f6 · d48f9f6
1 parent b2113f2
commit d48f9f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/main/java/com/fasterxml/jackson/databind/ser/BasicSerializerFactory.java b/src/main/java/com/fasterxml/jackson/databind/ser/BasicSerializerFactory.java
@@ -900,9 +900,7 @@ protected MapSerializer _checkMapContentInclusion(SerializerProvider prov,
             break;
         case CUSTOM: // new with 2.9
             valueToSuppress = prov.includeFilterInstance(null, inclV.getContentFilter());
-            if (valueToSuppress == null) { // is this legal?
-                suppressNulls = true;
-            } else {
+            if (valueToSuppress != null) { // is this legal?
                 suppressNulls = prov.includeFilterSuppressNulls(valueToSuppress);
             }
             break;
@@ -967,9 +965,7 @@ protected JsonSerializer<?> buildMapEntrySerializer(SerializerProvider prov,
             break;
         case CUSTOM:
             valueToSuppress = prov.includeFilterInstance(null, inclV.getContentFilter());
-            if (valueToSuppress == null) { // is this legal?
-                suppressNulls = true;
-            } else {
+            if (valueToSuppress != null) { // is this legal?
                 suppressNulls = prov.includeFilterSuppressNulls(valueToSuppress);
             }
             break;

diff --git a/src/main/java/com/fasterxml/jackson/databind/ser/impl/MapEntrySerializer.java b/src/main/java/com/fasterxml/jackson/databind/ser/impl/MapEntrySerializer.java
@@ -270,10 +270,8 @@ public JsonSerializer<?> createContextual(SerializerProvider provider,
             }
         }
 
-        MapEntrySerializer mser = withResolved(property, keySer, ser,
-                valueToSuppress, suppressNulls);
         // but note: no (full) filtering or sorting (unlike Maps)
-        return mser;
+        return withResolved(property, keySer, ser, valueToSuppress, suppressNulls);
     }
 
     /*