Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore "message" property for deserialization of custom Throwable #4072

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Ignore "message" property for deserialization of custom Throwable #4072

merged 1 commit into from
Aug 20, 2023

Conversation

JooHyukKim
Copy link
Member

resolves #4071

@JooHyukKim JooHyukKim marked this pull request as ready for review August 9, 2023 13:58
@JooHyukKim JooHyukKim mentioned this pull request Aug 9, 2023
Closed
1 task
@cowtowncoder
Copy link
Member

I'll need to dig into this after returning from my vacation, but I have some concerns about this -- message should definitely be retained in cases where it can be passed via constructor. But perhaps fix here will not affect the case where suitable constructor is found and will allow "incomplete" constructors to be used. If so, this would work.

cowtowncoder
cowtowncoder approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after I read the full context)

@cowtowncoder cowtowncoder added this to the 2.16.0 milestone Aug 20, 2023
@cowtowncoder cowtowncoder merged commit efad166 into FasterXML:2.16 Aug 20, 2023
3 checks passed
@JooHyukKim JooHyukKim deleted the 4071-throwable branch August 20, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

Impossible to deserialize custom Throwable sub-classes that do not have single-String constructors
2 participants
@JooHyukKim @cowtowncoder