Correction of minor warning #4076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getDeclaredMethod always returns non-null
getDeclaredMethod always returns non-null
Since _hasNativeTypeIds and _hasNativeObjectIds are both the same value, calculating or is meaningless
|
Thanks! I think I'll merge this piece by piece since there are some changes I prefer not made, while others are legit. |
cowtowncoder
added a commit
that referenced
this pull request
Aug 19, 2023
|
Merged most of changes via 7f85d4a -- closing (left index-based looping, extra parentheses). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a correction of a minor warning found during code reading.
Only those that are easy to fix and that affect performance are fixed (but not those that are likely to have a significant impact).