-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Records+JsonAnySetter workarounds shared in #3439, as test cases. #4633
Conversation
src/test-jdk17/java/com/fasterxml/jackson/databind/records/RecordWithJsonAnySetterTest.java
Outdated
Show resolved
Hide resolved
Ok, as per my note, I don't like the idea of test that verifies incorrect behavior. |
Should I just remove the test cases for workarounds that are no longer working? Putting them in |
Ah. Yes, if that's the case, let's just remove them. I was assuming they were to be resolved in future. |
…'t really care even if it somehow works again in the future.
Turns out there WAS test created for Records+JsonAnySetter, but the scenario is only when That explains why it didn't catch the regression caused by #4627. |
Now that I know RecordCreatorWithAnySetter562Test.java exists, I'll rewrite-move my tests into that class. |
Seems like this has become a duplicate of fb82b5b. Closing. |
2 out of 3 workarounds no longer work, but I still added them anyway for awareness.UPDATE: Removed them.