This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
Develop #24
Open
Develop #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect(Object forValue)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://groups.google.com/forum/#!topic/jackson-dev/QDkhQBD3PaA
Hi Tatu
According to our discussion, this is our changes to the CBOR dataformat that allows the usage of bounded arrays and objects. No changes to the API has been done. The implementation in CBORGenerator has slightly changed for:
• writeStartArray()
• writeStartArray(int size)
• writeEndArray()
• writeStartObject()
• writeStartObject(Object forValue)
• writeEndtObject ()
We added:
• writeStartObject (int size) (new method)
• Stack _arraySize
• Stack _objectSize
The class CBORGeneratorSizer decorates CBORGenerator permits the queuing of writing commands defined in CBORCommands. We stack the commands until the end of objects or arrays.
We created another Factory to avoid impacting CBORFactory. Also we want both functionality available since our approach can have some drawbacks on memory usage.
Thanks,