Change IntervalDeserializer to respect input timezone when enabled
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `IntervalDeserializer` to use `Interval.parseWithOffset` and override timezone only if `shouldAdjustToContextTimeZone` is set or explicit timezone is specified in the format Add unit tests for `IntervalDeserializer` to cover the 3 scenarios: - Timezone explicitly provided in deserialization format - Context timezone enabled - Neither context timezone enabled nor explicit timezone provided Resolve: #104
|
@cowtowncoder any idea why CI is failing - it looks as though the dependency snapshot version has been corrupted - |
|
@Woodz Not sure, I'll have a look. Maybe need to manually re-deploy; snapshots should auto-build via Travis but... maybe Sonatype Nexus has had issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
IntervalDeserializerto useInterval.parseWithOffsetandoverride timezone only if
shouldAdjustToContextTimeZoneis set orexplicit timezone is specified in the format
Add unit tests for
IntervalDeserializerto cover the 3 scenarios:Resolve: Deserializing Interval discards timezone information #104