Add kotlin/xml related test for regression in Jackson 2.12.x #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrik242
force-pushed
the
missing-constructor-2-12
branch
from
4400590
to
0acb852
Compare
henrik242
force-pushed
the
missing-constructor-2-12
branch
from
0acb852
to
3c37745
Compare
|
This seems to only affect the Kotlin module, which has the XML module as a test dep, so this can just live in jackson-module-kotlin FasterXML/jackson-module-kotlin#401 |
|
@dinomite Haha, that's where this issue started before @cowtowncoder moved it to the xml module. Full round trip! |
|
Thanks! I'll merge this here, then (I think it's fine to have little bit of overlap even if Kotlin module has the same test). |
henrik242
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See FasterXML/jackson-module-kotlin#396