-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide singleton support #307
Hide singleton support #307
Conversation
I would actually suggest slightly different approach: use of an Enum, with descriptive names (and Javadocs matching). This because I think there are 3 options, as per earlier discussions:
The main benefit, I think is just that there may be other approaches to add in future. Enum may also be used with annotations just in case there needs to be per-class override (granted for that may want programmatic access or something). |
Great idea, I'll get that updated shortly. Minor side benefit: one less boolean. |
Updated with an enum, let me know what you think. If this looks good, I'd like to merge this and leave the enhancements (dummy deserialize, those described in #281 etc.) to a separate PR. |
Great, looks good. Apologies for delays; I will try to follow up more closely as this is the number 1 priority for me to get included before doing first (and maybe only) 2.11 pre-release candidate. |
👍 An RC for this sounds like a good idea to me. |
Merge after #306
As discussed in issue #281, hide Kotlin singleton object deserialization behind a feature flag,
enableExperimentalSingletonSupport
.