Fix Github145 test #375
Merged
Fix Github145 test #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinomite
added
the
good first issue
|
I'll gladly accept PRs to this branch or ProTip®s as to what I'm not seeing is wrong. |
|
Sounds good to me? I do not remember context for ignoral (there's no comment next to it?). |
|
@cowtowncoder Oh, I just ignored it prior to this PR—after setting up CircleCI it became apparent this test was broken, but not clear when it broke. |
|
I added a note to the ignore on 2.12 and merged it into here. Also labeled this PR so we remember to address this for 2.12. |
|
…and gave this PR a meaningful title. |
|
I wonder if FasterXML/jackson-databind#1498 fix might be related here: 1-arg creator detection can now be made to work with databind (although default behavior should not change). |
Conflicts: src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github145.kt
|
This was incidentally fixed by some other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test broke at some point in the past. It's ignored on the
2.12branch; this branch un-ignores it so it can be fixed.Test itself was added for #145 ?