Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by invoke KFunction by "call". #408

Closed
wants to merge 5 commits into from

Conversation

k163377
Copy link
Contributor

@k163377 k163377 commented Jan 10, 2021

Pull request for Issue #403.

Additional

From reading the Branches in the README, I thought this change would be for 2.13, but since 2.13 doesn't seem to exist at present, I'm tentatively sending a pull request for 2.12.
Fixed.

TODO: Appropriate branch settings and CLA submission

done.

@cowtowncoder
Copy link
Member

I just created 2.13. It's up to @dinomite and @viartemev to determine where this should go, depending on likelihood of regressions, but 2.13 branch now exists (as of 8 hours ago or so)

@k163377 k163377 force-pushed the improve-performance branch from 1d6198e to 18ed9b2 Compare January 11, 2021 06:51
@k163377 k163377 changed the base branch from 2.12 to 2.13 January 11, 2021 06:52
@k163377 k163377 marked this pull request as ready for review January 12, 2021 10:40
@k163377
Copy link
Contributor Author

k163377 commented May 4, 2021

I will close when #439 is merged.

@dinomite
Copy link
Member

dinomite commented May 5, 2021

I'll be looking at this and the other PRs (#438, #439) over the next few days. I think 2.13 is probably the best place for them.

@dinomite
Copy link
Member

dinomite commented May 6, 2021

I'm unable to get mvn compile to work—the change to the sources directory has made it so that the compiler plugin can't find the package version which is generated by the com.google.code.maven-replacer-plugin:

[ERROR] Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.4.21:compile (compile) on project jackson-module-kotlin: Compilation failure
[ERROR] /Users/dinomite/Dropbox/code/misc/jackson-module-kotlin/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt:[37,18] Unresolved reference: PackageVersion

I pushed to a branch in the main repo, so that CircleCI could run, which shows the full error.

@k163377
Copy link
Contributor Author

k163377 commented May 6, 2021

@dinomite
As far as I have tried locally, the following changes seemed to work, so please check them (also reflected in #439).
d26df02

Since the content of this PR largely conflicts with #439 and is less effective, I thought it would be better not to merge it.
As for the review, I would appreciate it if you could give priority to #438 and #439.

@k163377
Copy link
Contributor Author

k163377 commented Jan 26, 2022

This change will be merged in #538.

@k163377 k163377 closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants