Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue # 580 - Lazy load UNIT_TYPE #616

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

sarbyn
Copy link
Contributor

@sarbyn sarbyn commented Jan 18, 2023

Fix using lazy init

Issue #580

@sarbyn sarbyn changed the title Update KotlinAnnotationIntrospector.kt Issue # 580 - Lazy load UNIT_TYPE Jan 18, 2023
@cowtowncoder
Copy link
Member

I assume this makes sense (I don't maintain the module nor know the code base well), looks simple enough. But would it be possible to add a basic unit test to verify working (fails before patch, work after)?

@sarbyn
Copy link
Contributor Author

sarbyn commented Jan 19, 2023

Yes...but how to test this scenario, a lazy init of a static val?

@cowtowncoder
Copy link
Member

Yes...but how to test this scenario, a lazy init of a static val?

I guess I do not know Kotlin well enough to really have good suggestions (or more importantly, be confident there is no practical way).
But it does seem (reading the issue again) that it'd be difficult to reliably verify from unit tests so probably it's fine.
So manual verification (via things that use Jackson) has to suffice.

@cowtowncoder cowtowncoder merged commit 16ec5f2 into FasterXML:2.15 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants