Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#219 relax jakarta.xml.bind OSGI version dependency #221

Closed
wants to merge 1 commit into from

Conversation

col-panic
Copy link

Generates the following Import-Package rules on build

Import-Package: jakarta.xml.bind;version="[3.0,4.0.100)",jakarta.xml.bin
 d.annotation;version="[3.0,4.0.100)",jakarta.xml.bind.annotation.adapte
 rs;version="[3.0,4.0.100)",com.fasterxml.jackson.annotation;version="[2
 .16,3)",com.fasterxml.jackson.core;version="[2.16,3)",com.fasterxml.jac
 kson.core.util;version="[2.16,3)",com.fasterxml.jackson.databind;versio
 n="[2.16,3)",com.fasterxml.jackson.databind.cfg;version="[2.16,3)",com.
 fasterxml.jackson.databind.deser.std;version="[2.16,3)",com.fasterxml.j
 ackson.databind.introspect;version="[2.16,3)",com.fasterxml.jackson.dat
 abind.jsonFormatVisitors;version="[2.16,3)",com.fasterxml.jackson.datab
 ind.jsontype;version="[2.16,3)",com.fasterxml.jackson.databind.jsontype
 .impl;version="[2.16,3)",com.fasterxml.jackson.databind.node;version="[
 2.16,3)",com.fasterxml.jackson.databind.ser.std;version="[2.16,3)",com.
 fasterxml.jackson.databind.type;version="[2.16,3)",com.fasterxml.jackso
 n.databind.util;version="[2.16,3)",com.fasterxml.jackson.module.jakarta
 .xmlbind.deser;version="[2.16,3)",com.fasterxml.jackson.module.jakarta.
 xmlbind.ser;version="[2.16,3)",jakarta.activation;version="[2.0,3)",jav
 ax.activation;resolution:=optional

thus enabling patch versions for jakarta.xml 4.0

@col-panic
Copy link
Author

col-panic commented Oct 2, 2023

Another approach would be to change <version.xmlbind.api> to 4.0.1, which leaves Import-Package like this

Import-Package: com.fasterxml.jackson.annotation;version="[2.16,3)",com.
 fasterxml.jackson.core;version="[2.16,3)",com.fasterxml.jackson.core.ut
 il;version="[2.16,3)",com.fasterxml.jackson.databind;version="[2.16,3)"
 ,com.fasterxml.jackson.databind.cfg;version="[2.16,3)",com.fasterxml.ja
 ckson.databind.deser.std;version="[2.16,3)",com.fasterxml.jackson.datab
 ind.introspect;version="[2.16,3)",com.fasterxml.jackson.databind.jsonFo
 rmatVisitors;version="[2.16,3)",com.fasterxml.jackson.databind.jsontype
 ;version="[2.16,3)",com.fasterxml.jackson.databind.jsontype.impl;versio
 n="[2.16,3)",com.fasterxml.jackson.databind.node;version="[2.16,3)",com
 .fasterxml.jackson.databind.ser.std;version="[2.16,3)",com.fasterxml.ja
 ckson.databind.type;version="[2.16,3)",com.fasterxml.jackson.databind.u
 til;version="[2.16,3)",com.fasterxml.jackson.module.jakarta.xmlbind.des
 er;version="[2.16,3)",com.fasterxml.jackson.module.jakarta.xmlbind.ser;
 version="[2.16,3)",jakarta.activation;version="[2.1,3)",jakarta.xml.bin
 d;version="[4.0,5)",jakarta.xml.bind.annotation;version="[4.0,5)",jakar
 ta.xml.bind.annotation.adapters;version="[4.0,5)",javax.activation;reso
 lution:=optional

but that isn't reasonable, as it does not allow for Java EE9 wich jaxb 3.

@cowtowncoder
Copy link
Member

@col-panic Looks like CI failed, not related to this PR. But re-created as #222 just in case. Thank you for the fix -- it will be in 2.16.0; hoping to get 2.16.0-rc1 released some time this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants